Improve lane markings and unify surface values#882
Closed
goteusz-maszyk wants to merge 4 commits into
Closed
Conversation
822b404 to
6403925
Compare
Owner
Contributor
Author
|
hi, I fixed the conflicts but I probably broke something I didn't notice right now I'll check it tomorrow |
Contributor
Contributor
Author
|
I'll check what can be done :) |
…urface handling across highways, leisure, and railways NOTE: it compiles, but I'm not sure if everything works
NOTE: I AM NOT SURE IF EVERYTHING WORKS # Conflicts: # src/element_processing/highways.rs
Owner
|
Thanks, great result! Sorry for the delay in reviewing it :D |
louis-e
added a commit
that referenced
this pull request
Apr 23, 2026
Rebases goteusz-maszyk's PR #882 onto current main, keeping main's terrain-flattening architecture (perpendicular median, row_medians cache, direction-aware curb outlines, road-surface-Y registration) while integrating the PR's user-visible improvements: - New `surfaces` module with `get_blocks_for_surface` / `get_blocks_for_surface_way` / `semirandom_surface`, shared by highways, leisure, and railways (platform=*). - OSM `surface=*` tag now drives the road block mix (was only applied to pedestrian plazas before). - OSM `width=*` tag now overrides the default block-range for a way (clamped to the terrain helper's sample cap). - `lanes=*` drives inner lane-divider count; `lane_markings=no` disables them. Dividers are drawn per centerline bresenham point with a proper dash/gap state machine (fixing the solid-line regression in an earlier PR iteration) and their Y still rides the perpendicular-median-flat cross section. - `indoor=yes` plus normalised `layer=*` are hoisted to the top of the highway function so street_lamp / bus_stop now rise with their overpass instead of sitting at ground level. - Flat-roofed outlines stay as main's direction-aware `x ± (block_range+1)` / `z ± (block_range+1)` curbs — the PR's four-sided box outline overwrote road edges and is dropped. - Unused `set_block_flag_absolute` helper removed; the `set_block` → `set_block_absolute` delegation from the PR is kept. Squashes the PR's four commits because its follow-up fixes depended on the initial refactor which needed heavy rework against main's new terrain-flattening pipeline. Co-authored-by: goteusz-maszyk <goteusz-maszyk@users.noreply.github.com>
louis-e
added a commit
that referenced
this pull request
Apr 23, 2026
Rebase #882: unify surfaces and add multi-lane markings onto main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




oh also add railway platforms, sorry for mixing commits
I also made the program respect more tags on highways