Skip to content

Fix visual appearance of Utah State Capitol building#894

Merged
louis-e merged 1 commit into
mainfrom
utah-capitol-fix
Apr 6, 2026
Merged

Fix visual appearance of Utah State Capitol building#894
louis-e merged 1 commit into
mainfrom
utah-capitol-fix

Conversation

@louis-e

@louis-e louis-e commented Apr 6, 2026

Copy link
Copy Markdown
Owner

Fixes #888

Copilot AI review requested due to automatic review settings April 6, 2026 17:31
@louis-e louis-e merged commit 38d81b0 into main Apr 6, 2026
4 checks passed
@louis-e louis-e deleted the utah-capitol-fix branch April 6, 2026 17:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the building generator’s hard-coded skip list so that the Utah State Capitol OSM way is not generated as a conventional building, allowing its building:part geometry to define the correct visual details.

Changes:

  • Add Utah State Capitol (way ID 32920861) to the SKIP_WAY_IDS list in generate_buildings.
  • Update the accompanying comment to include Utah State Capitol.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

github-actions Bot commented Apr 6, 2026

Copy link
Copy Markdown

⏱️ Benchmark run finished in 1m 30s
🧠 Peak memory usage: 1718 MB

📈 Compared against baseline: 30s
🧮 Delta: 60s
🔢 Commit: 7ecc404

🚨 This PR drastically worsens generation time.

📅 Last benchmark: 2026-04-06 17:36:43 UTC

You can retrigger the benchmark by commenting retrigger-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] 3D buildings generate incorrectly

2 participants