Better traffic lights#901
Conversation
|
Seeing this finally work after hours was great! |
There was a problem hiding this comment.
Pull request overview
Updates the generated “crossing:traffic_signals” highway element to use a wall-banner pattern design for more detailed, smaller traffic lights, with supporting changes to write banner block-entity data for both Java Anvil and Bedrock .mcworld outputs.
Changes:
- Add
WorldEditor::place_wall_bannerplus Java/Bedrock banner block-entity writers. - Fix Bedrock serialization for
block_entities/entitiesrecords to write concatenated NBT compounds (Bedrock LevelDB format). - Update highway traffic-signal placement to use banners + add required block definitions and Bedrock block mapping.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/world_editor/mod.rs | Adds banner placement helper and writes banner block-entity NBT into the per-chunk block_entities list for Java/Bedrock. |
| src/world_editor/bedrock.rs | Changes Bedrock LevelDB writing of entity/block-entity records to concatenated-compound encoding. |
| src/element_processing/highways.rs | Replaces wool-stack traffic lights with banner-based traffic lights around a pole. |
| src/block_definitions.rs | Introduces new internal block IDs for black_wool and light_gray_wall_banner. |
| src/bedrock_block_map.rs | Maps light_gray_wall_banner (with facing) and black_wool to Bedrock equivalents. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
LGTM |
|
retrigger-benchmark |
|
⏱️ Benchmark run finished in 1m 38s 📈 Compared against baseline: 30s 🚨 This PR drastically worsens generation time. 📅 Last benchmark: 2026-04-12 17:59:35 UTC You can retrigger the benchmark by commenting |
I used a custom banner pattern for the traffic lights to make them one block smaller and more detailed.
Works on Java & Bedrock edition.