refactor: make ImageBundlePlugin.imageBundles private#1052
Merged
redfish4ktc merged 1 commit intoApr 27, 2026
Conversation
The property is plugin-internal state; exposing it on the public API serves no caller use case and locks the implementation to today's array shape. Tests still need to inspect it, so they use a local `internals()` cast helper defined inside the test file — production code, stories, and downstream consumers cannot reach the property through the type system. Not a breaking change: ImageBundlePlugin was introduced in c3e4de1 and has not been released. Generated with Claude Code (claude-opus-4-7).
WalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The property is plugin-internal state; exposing it on the public API serves no caller use case and locks the implementation to today's array shape. Tests still need to inspect it, so they use a local
internals()cast helper defined inside the test file — production code, stories, and downstream consumers cannot reach the property through the type system.Not a breaking change: ImageBundlePlugin was introduced in c3e4de1 and has not been released.
Notes
Generated with Claude Code (claude-opus-4-7).