chore: share Claude build-protection config and trim rule bloat#1086
Merged
Conversation
Make the build-protection hook actually reach contributors and tidy two rule files. - Add a committed .claude/settings.json that registers the block-build.sh PreToolUse hook. The hook script was already tracked, but its registration lived only in the gitignored settings.local.json, so contributors who cloned the repo got the script without it ever firing. The file also ships a minimal read-only allowlist (git status/diff/log/show/branch) to cut first-run approval prompts. Entries are kept portable: no IDE/MCP-specific or absolute-path rules, which belong in each user's settings.local.json instead. - coding-practices: drop the duplicated .prettierrc values (tab width, quotes, print width). Prettier formats automatically, so restating its config prevents no mistake and risks drifting from the source of truth. - commit-conventions: remove the paths: ["**"] frontmatter. Matching every file is just a roundabout always-on rule; dropping it makes the always-on intent explicit and avoids the overly-broad path anti-pattern.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
WalkthroughThis PR updates the Claude project configuration by simplifying formatting rules documentation, cleaning up commit convention metadata, and introducing a new ChangesClaude Configuration and Rules Updates
Possibly related PRs
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tidies the repository's Claude Code configuration so the existing build-protection hook actually reaches contributors, and removes two small bits of rule bloat.
Changes
Share the build-protection hook (
.claude/settings.json, new)The
block-build.shPreToolUse hook script was already tracked in the repo, but its registration lived only in the gitignoredsettings.local.json. As a result, anyone cloning the repo got the script without it ever firing.This adds a committed
.claude/settings.jsonthat:block-build.shPreToolUse hook via$CLAUDE_PROJECT_DIR(portable across machines), andgit status/diff/log/show/branch) to reduce first-run approval prompts.Entries are intentionally portable: no IDE/MCP-specific or absolute-path rules, which belong in each contributor's own
settings.local.json.Trim rule bloat
coding-practices.md: drop the duplicated.prettierrcvalues (tab width, quotes, print width). Prettier formats automatically, so restating its config prevents no mistake and risks drifting from the source of truth. Replaced with a pointer to.prettierrc.commit-conventions.md: remove thepaths: ["**"]frontmatter. Matching every file is just a roundabout always-on rule; dropping it makes the always-on intent explicit and avoids the overly-broad path anti-pattern.Notes
No production code or build behavior is affected; all changes are under
.claude/.Summary by CodeRabbit
Documentation
Chores