fix: allow to insert vertex without setting position and size#555
Merged
tbouffard merged 5 commits intoNov 3, 2024
Merged
Conversation
This was allowed in mxGraph, and it is useful in scenario involving layouts (which is in charge of computing the position). The size of a vertex is sometime computed after the insertion, like in the OrgChart story. Update the signature of both the createVertex and insertVertex methods, and improve the related JSDOC. When the position is not set, the default values of the Geometry instance are used. Refactor tests: introduce helpers functions to remove duplication and make the expectations easier to read.
9 tasks
tbouffard
commented
Nov 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was allowed in mxGraph, and it is useful in scenario involving layouts (which is in charge of computing the position).
The size of a vertex is sometime computed after the insertion, like in the OrgChart story.
Update the signature of both the createVertex and insertVertex methods, and improve the related JSDoc.
When the position is not set, the default values of the Geometry instance are used.
Refactor tests: introduce helpers functions to remove duplication and make the expectations easier to read.
Notes
Detected in #532