ci: run with ubuntu-24.04#861
Conversation
|
WalkthroughThe GitHub Actions workflow files were updated to use the Ubuntu 24.04 runner environment instead of Ubuntu 22.04 or ubuntu-latest for all jobs that previously used older Ubuntu versions. No workflow logic, steps, or permissions were changed, and macOS/Windows runners remain unchanged. Changes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/publish-npm-package.yml (1)
8-8: Same availability concern for the publish jobThe comment above about the possible unavailability of
ubuntu-24.04applies here as well.
Publishing must be as reliable as possible, so a fallback (or usingubuntu-latest) may be safer.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/build.yml(1 hunks).github/workflows/create-github-release.yml(1 hunks).github/workflows/generate-website.yml(2 hunks).github/workflows/publish-npm-package.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: tbouffard
PR: maxGraph/maxGraph#593
File: .github/workflows/create-github-release.yml:0-0
Timestamp: 2025-01-28T16:31:02.890Z
Learning: In GitHub Actions workflows, explicit error handling is often unnecessary as:
1. Steps automatically fail when commands return non-zero exit codes
2. GitHub CLI (gh) provides detailed error messages in the logs by default
Learnt from: tbouffard
PR: maxGraph/maxGraph#849
File: packages/html/stories/DragSource.stories.js:98-101
Timestamp: 2025-06-13T07:48:10.300Z
Learning: User tbouffard prefers answers in English; avoid switching to other languages in future replies.
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build (windows-2022)
- GitHub Check: build (ubuntu-24.04)
🔇 Additional comments (4)
.github/workflows/create-github-release.yml (1)
10-10: Pinning toubuntu-24.04may break if the runner image is still in preview
ubuntu-24.04only became generally available very recently.
If GitHub temporarily withdraws or renames the image, the whole release flow will be unable to start.Consider one of the two mitigations:
- runs-on: ubuntu-24.04 + # Prefer the specific image only when strictly required + # runs-on: ubuntu-latest + runs-on: ubuntu-24.04or add a preliminary “image availability” matrix/condition to fall back to
ubuntu-latest..github/workflows/build.yml (1)
40-40: Verify that the build-setup action installs the right toolchain on 24.04The
build-setupcomposite action likely relies onapt-get install …or pre-installed language/tool versions.
Package names and default versions changed between 22.04 and 24.04 (e.g.,libc6-dev,libssl3,python3.12).Please run the workflow once on a feature branch and check for “package not found” or version-mismatch errors before merging.
.github/workflows/generate-website.yml (2)
45-45: Website build job runner updatedLGTM – no additional concerns beyond the general runner-availability note already mentioned.
76-76: Deploy job runner updated
actions/deploy-pages@v4is tested onubuntu-latest; however, the action is OS-agnostic, so this should be fine.
Still, keep an eye on the first deployment – page uploads sometimes fail when the underlyingrsync/tarversions change.
Summary by CodeRabbit