Replace alert in web api, scrollwidth property - #34733
Merged
Merged
Conversation
evelinabe
requested review from
a team and
wbamberg
and removed request for
a team
July 9, 2024 11:07
Contributor
|
Preview URLs (comment last updated: 2024-07-12 15:40:48) |
27 tasks
Josh-Cena
reviewed
Jul 11, 2024
Josh-Cena
reviewed
Jul 12, 2024
Josh-Cena
approved these changes
Jul 12, 2024
Josh-Cena
left a comment
Member
There was a problem hiding this comment.
Looks great! Thanks a bunch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
✍️ I have updated the example for the
scrollWidthproperty. My intention was to only remove the alert function, but since the example code didn't follow the styling guides I grouped the code to code blocks and added some additional texts about the example as well.Motivation
❓ They get a working example for
scrollWidth, and the code will be easier to read when it is grouped in code blocks.Additional details
🔗 #7566
Related issues and pull requests
See additional details