[Fix 177]: Throw exception when spec version is not recognized by reader#181
Merged
Conversation
…not recognized in Reader
added 2 commits
January 16, 2018 11:53
…t with writer exceptions and added spec version property to exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #177 for context.
I've introduced a fundamental exception type of
OpenApiReaderExceptionand throw anOpenApiUnsupportedSpecVersionExceptionwhen we encounter an unrecognized version. The former exception type is meant to be the base type for any more specific exception types to come in future.Test added with version 1.0.0, which I assume we'll never support, so the test should be robust in future versions of OpenAPI spec.