Static events should not use the auto trick - #1158
Merged
Scott Jones (Scottj1s) merged 1 commit intoJun 8, 2022
Merged
Conversation
The same way we don't use the auto trick for static properties and static methods.
Raymond Chen (oldnewthing)
requested review from
Scott Jones (Scottj1s) and
Kenny Kerr (kennykerr)
June 8, 2022 21:34
| return; | ||
| } | ||
|
|
||
| auto is_opt_type = settings.component_opt && settings.component_filter.includes(type); |
There was a problem hiding this comment.
is_component_type?
Member
Author
There was a problem hiding this comment.
It's "is optimized component type". non-optimized components still can use auto.
Scott Jones (Scottj1s)
approved these changes
Jun 8, 2022
Scott Jones (Scottj1s)
left a comment
Member
There was a problem hiding this comment.
thanks for the quick turnaround!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same way we don't use the auto trick for static properties and static methods.
Fixes issue introduced by #1136