Fix C4819 warning: replace non-ASCII em dash in base_macros.h comment - #1606
Merged
Conversation
…e_macros.h comment
Copilot
AI
changed the title
[WIP] Fix warning C4819 caused by non-ASCII character in C++/WinRT
Fix C4819 warning: replace non-ASCII em dash in base_macros.h comment
Jul 8, 2026
Ryan Shepherd (DefaultRyan)
approved these changes
Jul 8, 2026
Ryan Shepherd (DefaultRyan)
marked this pull request as ready for review
July 8, 2026 18:49
Duncan Horn (dunhor)
approved these changes
Jul 8, 2026
Contributor
|
A whole copilot summon for a 1 character change lol |
Member
I know, right? But seriously, I'm working on something else at the moment, and didn't feel like creating a branch and validating it myself. 🤷♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An em dash
—(U+2014) in a comment instrings/base_macros.htriggered MSVC warning C4819 (character not representable in current code page), breaking builds with/WXenabled.strings/base_macros.h: Replace—with ASCII-in comment on line 47