Skip to content

Add Static Library project template. - #402

Merged
Scott Jones (Scottj1s) merged 7 commits into
microsoft:masterfrom
jlaanstra:user/jlaans/static-library-template
Oct 29, 2019
Merged

Add Static Library project template.#402
Scott Jones (Scottj1s) merged 7 commits into
microsoft:masterfrom
jlaanstra:user/jlaans/static-library-template

Conversation

@jlaanstra

@jlaanstra Johan Laanstra (jlaanstra) commented Oct 27, 2019

Copy link
Copy Markdown
Contributor

This PR adds a static library project with the same setup as those in the NuGetTest.sln.

Additionally I fixed a few cases where CX winmd generation was still enabled in other project templates.

There's additional setup required in the consuming project which I can't add to this project template. I think there might be ways for cppwinrt.exe to generate the correct module.g.cpp but since that's not available today, I'm not sure how to communicate this. Thoughts?

@jlaanstra
Johan Laanstra (jlaanstra) force-pushed the user/jlaans/static-library-template branch from 9dca0ab to fb3989c Compare October 27, 2019 22:13
@jlaanstra

Copy link
Copy Markdown
Contributor Author

Scott Jones (@Scottj1s) When merging we should probably do this one first. Then I need to update the other PR to apply the same changes to the new project template before we can merge #403 and #404

<Name>Static Library (C++/WinRT)</Name>
<Description>A project for a C++/WinRT Static Library that can be used by a Universal Windows Platform app</Description>
<ProjectType>VC</ProjectType>
<SortOrder>3000</SortOrder>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that for VS 2019, you'll also want to add an entry for this template into project-metadata.json, so that it shows up on keyword filters. I would use a sort order value there of maybe 215.5, so it shows up just beneath the runtime component project. Example PR:
https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/162259

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I'll submit that separate.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scott Jones (@Scottj1s) looks like I don't have permissions to create PRs there. Can I leave this part to you?

Comment thread vsix/ProjectTemplates/VC/Windows Universal/StaticLibrary/readme.txt Outdated
@Scottj1s
Scott Jones (Scottj1s) merged commit 916f926 into microsoft:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants