Provide winrt_activation_handler to hook/mock activation - #477
Merged
Conversation
Kenny Kerr (kennykerr)
requested review from
Ryan Shepherd (DefaultRyan) and
Scott Jones (Scottj1s)
January 16, 2020 04:20
Scott Jones (Scottj1s)
approved these changes
Jan 16, 2020
Comment on lines
+24
to
+28
| if (winrt_activation_handler) | ||
| { | ||
| return winrt_activation_handler(*(void**)(&name), guid_of<Interface>(), result); | ||
| } | ||
|
|
There was a problem hiding this comment.
This requires the custom activation handler to deal with all possible activation scenarios. In certain kinds of tests that might be an overkill. It would be nice to have a way for the custom handler to return a magic value signifying that it cannot handle that specific activation and the default activation procedure should just continue, something like:
if (winrt_activation_handler)
{
if (auto hr = winrt_activation_handler(*(void**)(&name), guid_of<Interface>(), result);
hr != E_NOTIMPL) {
return hr;
}
}
...There was a problem hiding this comment.
I agree - I've had need for this flexibility myself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #476
This is required by the Windows shell team.