abort - #868
Merged
Merged
Conversation
9 tasks
Chris Bracken (cbracken)
added a commit
to flutter-team-archive/engine
that referenced
this pull request
Mar 5, 2021
This fixes an issue in CppWinRT related to std::terminate(); the tool now uses abort() instead. CppWinRT patch: microsoft/cppwinrt#868 This also fixes a couple bugs in the README.md: * Uses tmp as the temp dir into which we unpack the nupkg archive rather than cppwinrt to avoid confusion with the containing directory, which is named cppwinrt. * Fixes a typo around the directory from which the cipd command should be executed.
This was referenced Mar 15, 2021
Member
|
Why did you change from |
Collaborator
Author
|
No, terminate just calls abort. The latter has better support from the clang tool chain. |
Hunter Freyer (hjfreyer)
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
This fixes an issue in CppWinRT related to std::terminate(); the tool now uses abort() instead. CppWinRT patch: microsoft/cppwinrt#868 This also fixes a couple bugs in the README.md: * Uses tmp as the temp dir into which we unpack the nupkg archive rather than cppwinrt to avoid confusion with the containing directory, which is named cppwinrt. * Fixes a typo around the directory from which the cipd command should be executed.
Christopher Crawford (chriscraws)
pushed a commit
to chriscraws/engine
that referenced
this pull request
Mar 23, 2021
This fixes an issue in CppWinRT related to std::terminate(); the tool now uses abort() instead. CppWinRT patch: microsoft/cppwinrt#868 This also fixes a couple bugs in the README.md: * Uses tmp as the temp dir into which we unpack the nupkg archive rather than cppwinrt to avoid confusion with the containing directory, which is named cppwinrt. * Fixes a typo around the directory from which the cipd command should be executed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switched remaining
std::terminatecalls toabort- more exhaustive testing with Clang still runs into issues in some dev environments.