Skip to content

Windows test - #905

Merged
Kenny Kerr (kennykerr) merged 3 commits into
masterfrom
windows-test
Mar 26, 2021
Merged

Windows test#905
Kenny Kerr (kennykerr) merged 3 commits into
masterfrom
windows-test

Conversation

@kennykerr

Copy link
Copy Markdown
Collaborator

Ryan Shepherd (@DefaultRyan) is this what you had in mind?

@DefaultRyan

Copy link
Copy Markdown
Member

Pretty much. While we're here, since structs have different codegen patterns than interfaces and runtime classes, it would also be a good idea to have a struct in the nested namespace that has a field coming from the main Windows namespace, like Rect.

@kennykerr

Copy link
Copy Markdown
Collaborator Author

Bingo, structs tripped up the type writer.

@kennykerr

Copy link
Copy Markdown
Collaborator Author

That smoked out a few more issues. Thanks Ryan Shepherd (@DefaultRyan)!

@kennykerr
Kenny Kerr (kennykerr) merged commit 122b732 into master Mar 26, 2021
@kennykerr
Kenny Kerr (kennykerr) deleted the windows-test branch March 26, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants