Skip to content

perf: use incremental build by default #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenytang-ms merged 4 commits into from
Apr 28, 2026
Merged

perf: use incremental build by default #998

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2ef6037
perf: use incremental build by default
wenytang-ms Apr 28, 2026
389e4f1
chore: update
wenytang-ms Apr 28, 2026
b342364
perf: add rebuild
wenytang-ms Apr 28, 2026
83ce062
fix:comments
wenytang-ms Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix:comments
  • Loading branch information
@wenytang-ms
wenytang-ms committed Apr 28, 2026
commit 83ce062c539d6c8f4e0eb2dfd4043520b8dc265e
6 changes: 4 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,8 @@
},
{
"command": "java.project.build.project",
"title": "%contributes.commands.java.project.build.project%"
"title": "%contributes.commands.java.project.build.project%",
"category": "Java"
},
{
"command": "java.project.clean.workspace",
Expand All @@ -187,7 +188,8 @@
},
{
"command": "java.project.rebuild",
"title": "%contributes.commands.java.project.rebuild%"
"title": "%contributes.commands.java.project.rebuild%",
"category": "Java"
},
{
"command": "java.view.package.revealInProjectExplorer",
Expand Down
4 changes: 2 additions & 2 deletions src/views/dependencyDataProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,15 +83,15 @@ export class DependencyDataProvider implements TreeDataProvider<ExplorerNode> {
window.showErrorMessage("The URI of the project is not available, you can try to trigger the command 'Java: Build Project' from Command Palette.");
Comment thread
wenytang-ms marked this conversation as resolved.
return;
}
commands.executeCommand(Commands.BUILD_PROJECT, Uri.parse(node.uri), false /*isFullBuild*/);
return commands.executeCommand(Commands.BUILD_PROJECT, Uri.parse(node.uri), false /*isFullBuild*/);
}));
Comment thread
wenytang-ms marked this conversation as resolved.
context.subscriptions.push(instrumentOperationAsVsCodeCommand(Commands.JAVA_PROJECT_REBUILD, async (node: INodeData) => {
if (!node.uri) {
sendError(new Error("Uri not available when rebuilding project"));
window.showErrorMessage("The URI of the project is not available, you can try to trigger the command 'Java: Rebuild Project' from Command Palette.");
Comment thread
wenytang-ms marked this conversation as resolved.
return;
}
commands.executeCommand(Commands.BUILD_PROJECT, Uri.parse(node.uri), true /*isFullBuild*/);
return commands.executeCommand(Commands.BUILD_PROJECT, Uri.parse(node.uri), true /*isFullBuild*/);
}));

this.setRefreshDebounceFunc();
Expand Down
12 changes: 12 additions & 0 deletions test/suite/buildTask.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,18 @@ suite("Build Task Tests", () => {
assert.strictEqual(exportJarTask.definition.isFullBuild, false);
});

test("test resolving build task defaults to incremental build", async function() {
const task: Task = new Task({
type: BuildTaskProvider.type,
paths: [ BuildTaskProvider.workspace ],
}, TaskScope.Workspace, BuildTaskProvider.defaultTaskName, BuildTaskProvider.type);

const resolvedTask: Task | undefined = await new BuildTaskProvider().resolveTask(task);

assert.ok(resolvedTask !== undefined);
assert.strictEqual(resolvedTask.definition.isFullBuild, false);
});

test("test categorizePaths()", async function() {
const [includes, excludes, invalid] = categorizePaths([
BuildTaskProvider.workspace,
Expand Down
Loading