Skip to content

(Maint)|Add Carthage support - #6

Merged
brettwellmanmbo merged 3 commits into
masterfrom
feature/add-carthage-support
Apr 20, 2017
Merged

(Maint)|Add Carthage support#6
brettwellmanmbo merged 3 commits into
masterfrom
feature/add-carthage-support

Conversation

@brettwellmanmbo

@brettwellmanmbo brettwellmanmbo commented Apr 18, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Branch master
Development Release
Unit Tests: No

Summary

  • Add shared scheme and iOS framework target to make this a framework consumable by Carthage
  • Fix workspace/project build errors & warnings
  • Remove internal cocoapod dependency for Demo target
  • Reorganize file structure some & remove some stagnant files

Test Plan

  • Build the workspace and run the demo app
  • Consume this framework in another project via Carthage

Mentions
@matt-holden
@Hammertime38

@brettwellmanmbo
Add Carthage support
b86e9b9 
- Add shared scheme and an iOS framework target to make this a
framework consumable by Carthage
- Fix broken workspace & project
- Fix broken MBDebugPanelDemo target
- Remove internal cocoapod dependency for itself (for Demo target)
- Fix all build issues
- Reorganize file structure some & remove some stagnant files
@brettwellmanmbo brettwellmanmbo self-assigned this Apr 18, 2017
@brettwellmanmbo
Add 'presentViewController:animated:completion' to public class metho…
bd94d14 
…d declarations
@brettwellmanmbo
Cleanup
9fc2ecb 
- Add -setTitle: to MBDebugPanel
- Remove plist files for nonexistent frameworks
- xCode autocorrected some project warnings
ErnieMBO
ErnieMBO approved these changes Apr 20, 2017
View reviewed changes

@ErnieMBO ErnieMBO left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R+

@brettwellmanmbo
brettwellmanmbo merged commit 13c9183 into master Apr 20, 2017
@brettwellmanmbo
brettwellmanmbo deleted the feature/add-carthage-support branch April 20, 2017 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@ErnieMBO ErnieMBO ErnieMBO approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@brettwellmanmbo brettwellmanmbo

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brettwellmanmbo @ErnieMBO