🛡️ Sentinel: Fix Command Injection in CLI deploy#6
Conversation
…on in CLI deploy 🚨 Severity: CRITICAL 💡 Vulnerability: Command Injection in `adk deploy` via Dockerfile generation. User-controlled inputs (like `allow_origins`, `session_service_uri`) were injected directly into the `CMD` instruction of the generated Dockerfile without quoting. 🎯 Impact: This could allow arbitrary code execution in the deployed container if malicious inputs are provided. 🔧 Fix: Sanitized all interpolated variables in Dockerfile generation using `shlex.quote()`. Updated `allow_origins` handling to generate multiple quoted flags. ✅ Verification: Updated unit tests `tests/unittests/cli/utils/test_cli_deploy.py` and `tests/unittests/cli/utils/test_cli_deploy_to_cloud_run.py` to assert correct quoting and argument formatting. Confirmed with reproduction script. Co-authored-by: mmontan <2553915+mmontan@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Sanitize inputs in
cli_deploy.pyto prevent Command Injection in generated Dockerfiles. Useshlex.quoteforallow_origins,adk_version, and service URIs. Also fixallow_originsargument passing to use multiple flags.PR created automatically by Jules for task 14397539230650318606 started by @mmontan