detect: read OTEL_IGNORE_ERROR from environment - #6966
Merged
Conversation
Signed-off-by: Simon Aguilera <saguilera1608@gmail.com>
tonistiigi
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Commit
228e250dmovedOTEL_IGNORE_ERRORhandling intodetectExporter, but therefactor passed the environment variable name directly to
strconv.ParseBoolinsteadof reading its value. Parsing the literal string always fails, so exporter errors cannot
be ignored even when
OTEL_IGNORE_ERROR=true.This restores the environment lookup used before that refactor.
Changes
OTEL_IGNORE_ERRORfrom the environment;The test uses an unknown exporter name, so it does not invoke a detector or connect to
an external telemetry backend.
Validation
All tests and vet pass, and
gofmt -lproduces no output.Behavior note
Operators with
OTEL_IGNORE_ERRORalready enabled will regain the error-suppressionbehavior that existed before the refactor.