Implement UnTar via archive/tar - #3295
Conversation
|
+1 |
|
@alexlarsson can you rebase? |
|
@creack I'm off for christmas, back jan 8th |
|
We just began requiring contributors to sign the commits following these rules: https://github.com/dotcloud/docker/blob/master/CONTRIBUTING.md#sign-your-work Each commit in your PR must be signed in the following format: Please rebase and sign each commit. |
|
Rebased with signoff |
|
+1! can you rebase with the new 1.1 signoff? (sorry about that) |
|
@tianon Not sure what you mean. The latest rebase has a 1.1 version signoff. |
|
Well shoot, so it does. Sorry about that! It does look like you've got some gofmt issues though. Not sure how I misread that Travis output. How embarrassing! |
|
@tianon What gofmt issues? I just ran "go fmt ." in archive/ and it made no changes. |
|
Try |
This way we can reuse it for Untar() Docker-DCO-1.1-Signed-off-by: Alexander Larsson <alexl@redhat.com> (github: alexlarsson)
This replaces the shelling out to tar with a reimplementation of untar based on the archive/tar code and the pre-existing code from ApplyLayer to create real files from tar headers. Docker-DCO-1.1-Signed-off-by: Alexander Larsson <alexl@redhat.com> (github: alexlarsson)
|
Ugh, sorry, was looking at the wrong tar branch... |
|
No worries, it happens. :) Travis is happy now! /cc @creack @crosbymichael @vieux |
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
Implement UnTar via archive/tar
…-pools Use private network address for default-address-pools setting in daem…
This replaces the shelling out to tar with a reimplementation of untar
based on the archive/tar code and the pre-existing code from ApplyLayer
to create real files from tar headers.