Skip to content

vendor: github.com/moby/go-archive v0.3.1 - #53260

Merged
thaJeztah merged 1 commit into
moby:masterfrom
vvoland:update-archive
Jul 31, 2026
Merged

vendor: github.com/moby/go-archive v0.3.1#53260
thaJeztah merged 1 commit into
moby:masterfrom
vvoland:update-archive

Conversation

@vvoland

@vvoland vvoland commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

full diff: moby/go-archive@v0.3.0...v0.3.1

Summary

Release notes (optional)

Fix a regression that prevented pulling images whose layers contain directories without explicit parent directory entries.

A picture of a cute animal (not mandatory but encouraged)

full diff: moby/go-archive@v0.3.0...v0.3.1

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland added this to the 29.7.1 milestone Jul 31, 2026
@vvoland vvoland self-assigned this Jul 31, 2026
Copilot AI review requested due to automatic review settings July 31, 2026 14:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the vendored github.com/moby/go-archive dependency to v0.3.1 to address #53257, a regression where extracting layers can fail when a tar contains a directory entry whose parent directory is implied (not explicitly present in the archive).

Changes:

  • Vendor bump github.com/moby/go-archive from v0.3.0 to v0.3.1 across go.mod, go.sum, and vendor/modules.txt.
  • Fix implied-directory handling during extraction by creating parent directories for all entry types (including directory entries), preventing mkdir ...: no such file or directory failures.
  • Reduce noisy error logging during tarball creation by ignoring io.ErrClosedPipe from close operations when the read-end is closed early.

Reviewed changes

Copilot reviewed 1 out of 4 changed files in this pull request and generated no comments.

File Description
vendor/github.com/moby/go-archive/archive.go Applies upstream fix for implied parent directories during extraction; adjusts Close error logging behavior.
vendor/modules.txt Updates vendored module version entry for github.com/moby/go-archive to v0.3.1.
go.mod Bumps required github.com/moby/go-archive dependency to v0.3.1.
go.sum Updates checksums for github.com/moby/go-archive v0.3.1.

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
thaJeztah merged commit f3737d9 into moby:master Jul 31, 2026
228 of 237 checks passed
chhe pushed a commit to chhe/act_runner that referenced this pull request Aug 8, 2026
Revert https://gitea.com/gitea/runner/pulls/1130. Docker 29.7.1 fixed both regressions it worked around, moby/moby#53261 and moby/moby#53260, so only 29.7.0 still needs it.

Verified live with a relative and an absolute `/var/run` symlink: without the workaround the copy passes on 29.4.0, 29.6.2 and 29.7.1, and fails on 29.7.0 alone.

Fixes: https://gitea.com/gitea/runner/issues/1131
Reviewed-on: https://gitea.com/gitea/runner/pulls/1155
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression in 29.7.0: pulling quay.io/buildah/stable fails with "failed to register layer: mkdirat etc/dnf: no such file or directory"

3 participants