Fix typos and clarify error handling for missing ttlMs#2747
Open
spacewander wants to merge 5 commits into
Open
Fix typos and clarify error handling for missing ttlMs#2747spacewander wants to merge 5 commits into
spacewander wants to merge 5 commits into
Conversation
Contributor
|
@CaitieM20 can you please take a look? |
CaitieM20
reviewed
May 21, 2026
CaitieM20
previously approved these changes
May 21, 2026
CaitieM20
left a comment
Contributor
There was a problem hiding this comment.
@spacewander this looks good to me, applied one minor patch to clarify the error handling is for backwards compatibility only, since ttlMS is required.
Merged in latest from main, I think you may need to re-run sep generation and style checks, and then I can merge.
Author
|
@CaitieM20 |
Author
|
@CaitieM20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context