Skip to content

[new locale] yo: Yoruba (Nigeria) locale#3435

Closed
realbisoye wants to merge 1 commit into
moment:developfrom
realbisoye:add-yoruba-locale
Closed

[new locale] yo: Yoruba (Nigeria) locale#3435
realbisoye wants to merge 1 commit into
moment:developfrom
realbisoye:add-yoruba-locale

Conversation

@realbisoye

Copy link
Copy Markdown

No description provided.

@realbisoye

Copy link
Copy Markdown
Author

@mj1856 Changes rebased into one single commit, thanks.

@mattjohnsonpint

Copy link
Copy Markdown
Contributor

Thanks. For future reference, you could have just rebased the existing branch and pushed, and it would have updated the original PR (#3424) instead of closing and creating a new one. But this is fine.

@realbisoye

Copy link
Copy Markdown
Author

Oh, noted. Thanks.

@maggiepint

Copy link
Copy Markdown
Member

Heads up. Because we came under JS Foundation management, we need a CLA signed for this to be merged. Should be just a couple clicks.

@realbisoye

Copy link
Copy Markdown
Author

@maggiepint, CLA agreement signed. I noticed there have been no updates on the checks though.

@JSFOwner

JSFOwner commented Nov 5, 2016

Copy link
Copy Markdown
Member

The author information in the commit is invalid. The commit must contain your username and email to pass the CLA signature check. Please update the commit with correct author information.

@realbisoye

Copy link
Copy Markdown
Author

@ichernev commit updated with author information.

@mattjohnsonpint mattjohnsonpint modified the milestones: 2.17.0, 2.16.0 Nov 10, 2016
ichernev added a commit that referenced this pull request Nov 12, 2016
[new locale] yo: Yoruba (Nigeria) locale
@ichernev

Copy link
Copy Markdown
Contributor

Merged in fae8004

@ichernev ichernev changed the title add locale for Yoruba, Nigeria [new locale] yo: Yoruba (Nigeria) locale Nov 12, 2016
@ichernev ichernev closed this Nov 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants