Make funcspace independent - #226
Merged
calixteman merged 1 commit intoAug 5, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
- Coverage 17.32% 17.28% -0.04%
==========================================
Files 46 46
Lines 5918 5918
Branches 698 698
==========================================
- Hits 1025 1023 -2
- Misses 4490 4493 +3
+ Partials 403 402 -1
Continue to review full report at Codecov.
|
Collaborator
|
Could you rebase please ? |
Collaborator
Author
|
We need to merge #224 first |
Luni-4
force-pushed
the
make-funcspace-independent
branch
from
August 4, 2020 14:04
b6fa108 to
77838b6
Compare
Collaborator
Author
|
Now it is ready to be merged, sorry for the mess :) |
calixteman
approved these changes
Aug 5, 2020
Collaborator
|
Thx |
spacedragon
pushed a commit
to spacedragon/rust-code-analysis
that referenced
this pull request
Feb 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the
FuncSpacestruct independent of a parser and should be merged after #223 and #225Thanks in advance for your review! :)