WebGPURenderer: Fix furnace test energy loss for intermediate metalness values#32201
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Owner
Author
|
@sunag looks good? |
Owner
Author
|
Oh, looks like |
Collaborator
Yes, that's great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #32190
Description
Fixes energy conservation issues in the physically-based lighting model when metalness is between 0 and 1.
The furnace test was losing energy for intermediate metalness values due to incorrect application of the Fdez-Agüera multiscattering formula, which is designed for pure dielectric OR conductor F0 values, not blended ones.
This fix follows the same approach used in the WebGLRenderer and matches the implementation used in EEVEE/Frostbite:
Changes:
diffuseContributionandspecularColorBlendedPropertyNodesMeshStandardNodeMaterialandMeshPhysicalNodeMaterialto compute material properties correctlyPhysicalLightingModel.computeMultiscattering()to accept F0 parameterPhysicalLightingModel.indirectSpecular()to compute separate multiscattering paths