Skip to content

Controls reset touch-action to empty string instead of 'auto'#33144

Merged
Mugen87 merged 1 commit into
mrdoob:devfrom
Kodub:fix/controls-restore-touch-action
Mar 9, 2026
Merged

Controls reset touch-action to empty string instead of 'auto'#33144
Mugen87 merged 1 commit into
mrdoob:devfrom
Kodub:fix/controls-restore-touch-action

Conversation

@Kodub

@Kodub Kodub commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

When controls are disconnected, sets touchAction = '' instead of touchAction = 'auto' so the inline style is removed from the canvas.

In most cases it makes no difference, but it matters if the canvas has CSS styling affecting the touch-action somewhere else.

Other fixes:

  • ArcballControls was not restoring touchAction at all
  • Set touchAction for FlyControls as well to align it with how other controls work

@Mugen87 Mugen87 added this to the r184 milestone Mar 9, 2026
@Mugen87 Mugen87 merged commit 24cbbb7 into mrdoob:dev Mar 9, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants