Skip to content

WebGPUTextureUtils: Fix copyTextureToBuffer() dispose buffer#33366

Merged
sunag merged 1 commit into
mrdoob:devfrom
sunag:dev-fix-dispose
Apr 11, 2026
Merged

WebGPUTextureUtils: Fix copyTextureToBuffer() dispose buffer#33366
sunag merged 1 commit into
mrdoob:devfrom
sunag:dev-fix-dispose

Conversation

@sunag

@sunag sunag commented Apr 11, 2026

Copy link
Copy Markdown
Collaborator

Related issue: N/A

Description

Fixed a memory leak by destroying the buffer after use.

@sunag sunag added this to the r184 milestone Apr 11, 2026
@github-actions

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 361.21
85.78
361.21
85.78
+0 B
+0 B
WebGPU 637.34
177.03
637.37
177.04
+30 B
+10 B
WebGPU Nodes 635.46
176.73
635.49
176.75
+30 B
+11 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 493.58
120.42
493.58
120.42
+0 B
+0 B
WebGPU 709.19
191.86
709.22
191.88
+30 B
+12 B
WebGPU Nodes 658.41
179.15
658.44
179.17
+30 B
+13 B

@sunag sunag marked this pull request as ready for review April 11, 2026 03:18
@sunag sunag merged commit 291280b into mrdoob:dev Apr 11, 2026
15 of 16 checks passed
@sunag sunag deleted the dev-fix-dispose branch April 11, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant