Replace dots with slashes in OTEL metric families for hierarchical grouping#21371
Merged
Conversation
Member
|
@copilot the fix is very simple - we need to replace dots with |
Member
No. You don't need to modify any go code. otel is rust only. |
…ouping Modified both the Rust and Go OTEL plugins to use slashes instead of dots in the family field, enabling hierarchical grouping in the dashboard. For example: - Before: otel.dotnet.exceptions - After: otel/dotnet/exceptions Also fixed a pre-existing bug in convert_test.go where Convert was called instead of convert (lowercase). Co-authored-by: ilyam8 <22274335+ilyam8@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix OTEL metrics grouping in dashboard
Replace dots with slashes in OTEL metric families for hierarchical grouping
Dec 1, 2025
Removed modifications to Go otel-collector code as per review feedback. The OTEL plugin is Rust-only. The fix only needs to replace dots with slashes in the family field in the Rust plugin. Co-authored-by: ilyam8 <22274335+ilyam8@users.noreply.github.com>
Contributor
Author
Member
|
@copilot remove "otel/" prefix in the family, we don't need it. |
The family field should just use the metric name with dots replaced by slashes, without the otel/ prefix (e.g., dotnet/exceptions instead of otel/dotnet/exceptions). Co-authored-by: ilyam8 <22274335+ilyam8@users.noreply.github.com>
Contributor
Author
sashwathn
approved these changes
Dec 2, 2025
Member
|
Flagging @vkalintiris for review on this as he’s the de-facto code owner. |
Member
|
After this change 
|
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Dec 3, 2025
…ouping (netdata#21371) Co-authored-by: ilyam8 <22274335+ilyam8@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> (cherry picked from commit d7f3bf3)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #21239
OTEL metrics appear as flat, ungrouped items in the dashboard because the family field uses dots as separators. This change replaces dots with slashes in metric family names to enable hierarchical grouping.
Before:
otel.dotnet.exceptions(flat)After:
dotnet/exceptions(grouped underdotnet)Changes:
src/crates/jf/otel-plugin/src/netdata_chart.rs): Generate family by replacing dots with slashes in the metric nameTest Plan
cargo checkpassesAdditional Information
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.