fix: add RequestInit duplex type - #1890
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Allow TypeScript users to pass Fetch's
duplex: 'half'option inRequestInit.Changes
RequestDuplextype andRequestInit.duplex.Requestwithduplex: 'half'.expectType<Request>(...)assertion so the type test is lint-clean.Additional information
Verified locally:
npx tsc --noEmit --skipLibCheck --lib es2020,dom --moduleResolution node --module esnext --target es2020 --esModuleInterop ".\@types\index.test-d.ts"npm run lintgit diff --checkNotes from broader local checks:
npm run test-typesstill fails in this checkout on existingFormData/Fileglobal type resolution after a fresh dependency install, but the newduplexassertion is no longer among the failures.npm testreached 386 passing and 3 pending, with 5 local network/timing failures under the current Node runtime.