fix: validate Response status in constructor per Fetch spec - #1893
Open
MD-Mushfiqur123 wants to merge 2 commits into
Open
fix: validate Response status in constructor per Fetch spec#1893MD-Mushfiqur123 wants to merge 2 commits into
MD-Mushfiqur123 wants to merge 2 commits into
Conversation
Currently the Host header appears as the last header in HTTP requests. Prepend it by explicitly setting it in the headers object before other headers, following convention used by browsers and other libraries. Relevant Node.js issue: nodejs/node#42496 Fixes node-fetch#1570
Add status range validation per https://fetch.spec.whatwg.org/#response-class. Status must be in the range 200-599, otherwise throw a RangeError. Also fix Response.error() to bypass constructor validation by setting status directly on the internal object, as network errors use status 0. Fixes node-fetch#1685
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add proper validation to the
Responseconstructor per the Fetch spec.Why
Per https://fetch.spec.whatwg.org/#response-class:
init["status"]is not in the range 200-599, throw aRangeErrorTypeErrorCurrently neither check is performed, allowing invalid Response objects to be created.
How
Added two checks at the start of the Response constructor:
Fixes #1685