fix: validate Response status range and null-body status per fetch spec - #1908
Open
marceli1404 wants to merge 1 commit into
Open
fix: validate Response status range and null-body status per fetch spec#1908marceli1404 wants to merge 1 commit into
marceli1404 wants to merge 1 commit into
Conversation
Add spec-compliant validation to the Response constructor: - Throw RangeError for status outside 200-599 - Throw TypeError for body provided with null-body status (204, 304) - Validate statusText for invalid characters - Modify Response.error() to bypass constructor validation - Use null body for internal 204/304 responses Closes node-fetch#1685
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Per the Fetch spec, the Response constructor should validate:
Changes
src/response.jsNULL_BODY_STATUSESset ([101, 204, 304])RangeErrorfor status outside [200, 599]TypeErrorwhen body is non-null with status 204/304/101Response.error()now usesReflect.constructto bypass constructor validation since it uses status 0src/index.jsnullbody instead of the response stream, since these statuses must not have a body per spectest/response.jsVerification