Skip to content

Descriptor fixes #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnhaley81 merged 2 commits into from
Apr 27, 2016
Merged

Descriptor fixes #1004

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2139c33
Fix annotated_commit annotation
srajko Apr 25, 2016
5aa7822
Fix git_remote_stats ownedByThis descriptor
srajko Apr 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix annotated_commit annotation 
Removing free from the list because it was not being honored anyway, and we have a test that uses this free
  • Loading branch information
@srajko
srajko committed Apr 27, 2016
commit 2139c33913b30e9f2cb60e9c862f87140f71ae79
5 changes: 1 addition & 4 deletions generate/input/descriptor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,8 @@
},
"types":
{
"annotated": {
"annotated_commit": {

@johnhaley81 johnhaley81 Apr 26, 2016

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this section completely? No use in having an empty section for this.

@srajko srajko Apr 27, 2016

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I fill it right back up in #1006.

"functions": {
"git_annotated_commit_free": {
"ignore": true
}
}
},
"attr": {
Expand Down