Skip to content

Fix postinstall script crash when install location has spaces in its path #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnhaley81 merged 1 commit into from
Jan 27, 2017
Merged

Fix postinstall script crash when install location has spaces in its path #1148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lifecycleScripts/postinstall.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ module.exports = function install() {
return Promise.resolve();
}

return exec("node " + path.join(rootPath, "dist/nodegit.js"))
return exec("node \"" + path.join(rootPath, "dist/nodegit.js\""))

@johnhaley81 johnhaley81 Jan 27, 2017

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like return exec("node \"" + path.join(rootPath, "dist/nodegit.js\"")) should instead be return exec("node \"" + path.join(rootPath, "dist/nodegit.js") + "\"") but this has been open for long enough. I'll fix that in a later PR.

.catch(function(e) {
if (~e.toString().indexOf("Module version mismatch")) {
console.warn(
Expand Down