RevertOptions parameter in Revert.revert is actually optional#1213
Merged
Conversation
libgit2's git_revert function does not require the revert options to be specified so the same should apply to the NodeGit API.
Collaborator
|
Awesome! Thanks again @rcjsuen :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libgit2's
git_revertfunction does not actually require the revert options to be specified. It is merely a documentation oversight on their website. We should flag thegiven_optsargument as beingisOptionalso thatnullcan be passed into the JavaScript function.