Skip to content

Define error codes to fix compiler warnings about unused variables#1486

Merged
implausible merged 1 commit into
nodegit:masterfrom
rcjsuen:unused
Aug 31, 2018
Merged

Define error codes to fix compiler warnings about unused variables#1486
implausible merged 1 commit into
nodegit:masterfrom
rcjsuen:unused

Conversation

@rcjsuen

@rcjsuen rcjsuen commented Apr 12, 2018

Copy link
Copy Markdown
Member

The result field for git_ignore_path_is_ignored and git_tag_list_match isn't being used so the compiler is generating warnings for the unused variable. I have fixed up descriptor.json so that they will be used.

../src/ignore.cc
:
192
:
7
:

warning
:
unused variable 'result' [-Wunused-variable]

int result = git_ignore_path_is_ignored(

^

CXX(target) Release/obj.target/nodegit/src/index_entry.o
1
warning
generated.
CXX(target) Release/obj.target/nodegit/src/index_time.o
CXX(target) Release/obj.target/nodegit/src/indexer.o
../src/tag.cc
:
1332
:
7
:

warning
:
unused variable 'result' [-Wunused-variable]

int result = git_tag_list_match(

^

4 warnings generated.
CXX(target) Release/obj.target/nodegit/src/time.o
CXX(target) Release/obj.target/nodegit/src/trace.o

Signed-off-by: Remy Suen <remy.suen@gmail.com>
@implausible implausible merged commit 61a0cab into nodegit:master Aug 31, 2018
@rcjsuen rcjsuen deleted the unused branch August 31, 2018 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants