Conversation
Collaborator
|
Lots of stuff doesn't work yet. |
Collaborator
|
There are some bugs in Combyne that need to be fixed and after that there's 1 issue in convertFromV8 that's still outstanding. |
This is the initial work for porting over the header template to use Combyne instead of EJS. It adds in a few helpers that are necessary to replace missing features that EJS provides like JS boolean logic.
Merged
tbranyen
added a commit
that referenced
this pull request
Oct 7, 2014
WIP: Refactor source generation templates from EJS to Combyne
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking branch changes.