Skip to content

Attempt remove the delete keyword #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbranyen merged 2 commits into from
Apr 20, 2015
Merged

Attempt remove the delete keyword #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fbb55f
Attempt remove the delete keyword
tbranyen Apr 9, 2015
c31ea4e
Shallow clone before mutating the options object
tbranyen Apr 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/clone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
var NodeGit = require("../");
var shallowClone = require("./utils/shallow_clone");
var normalizeOptions = NodeGit.Utils.normalizeOptions;

var Clone = NodeGit.Clone;
Expand All @@ -17,6 +18,7 @@ Clone.clone = function(url, local_path, options) {
var remoteCallbacks;

if (options) {
options = shallowClone(options);
remoteCallbacks = options.remoteCallbacks;
delete options.remoteCallbacks;
}
Expand Down
10 changes: 10 additions & 0 deletions lib/utils/shallow_clone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
module.exports = function(obj) {
var merges = Array.prototype.slice.call(arguments, 1);

return merges.reduce(function(obj, merge) {
return Object.keys(merge).reduce(function(obj, key) {
obj[key] = merge[key];
return obj;
}, obj);
}, obj || {});
};