Fix build issues with 0.4.0#566
Conversation
|
@maxkorp I think the false positives in CI should be a different PR. We should get this merged in ASAP IMO. |
There was a problem hiding this comment.
Isn't latest nan, 1.8.4? If that works, can we change this to ^1.8.4?
There was a problem hiding this comment.
Yeah, np. It was downloading 1.8.4 but we should up that regardless.
|
Seg faults in iojs on linux :( |
|
I'd like to get it working on iojs in linux before merging, but I'm cool waiting on the false positives thing. I can take a crack at it in a few. |
|
I'm unable to repo the seg fault on linux. @tbranyen could you give this a try? |
|
So apparently its an issue with iojs 2+. Any ideas/thoughts? |
|
Only in linux, OSX looks to be good. Have you tried windows? |
ed72733 to
9162c62
Compare
|
Removed the bumping nan and supporting io.js from this PR. |
9162c62 to
f73bf83
Compare
Fix build issues with 0.4.0
Fixes #565
Waiting to merge until we can get the false positives resolved