stream: preserve object mode in compose#47413
Conversation
|
Review requested:
|
|
@debadree25 Hey man, do you maybe know where to look to try fixing this flaky CI once and for all, it's exhausting |
|
Hi @rluvaton this is common occurrence, the failures don't seem related, dont worry I will resume the ci again! in case you are interested in helping in ci flakes you could check out the issue tracker filtering by the flaky-test label! you can also checkout nodejs/reliability repo for common occurences and maybe file issue reports/fix them |
benjamingr
left a comment
There was a problem hiding this comment.
This need a CITGM run before merging and probably a semver-major tag
If |
|
No need for major |
|
@mcollina Let's merge this think as it's being approved for more than 2 days 😄 |
|
this ${STATUS_LABEL} job randomly showing up in github CI as a red, would this conflict with landing? also i think a citgm run would be needed? |
|
What is CITGM? Is it testing using other npm packages? and it looks like it failed... |
|
Landed in 67fdb74 |
All good, thanks I love contributing to node! If there are other stream related issues don't hesitate to mention me 😀 |
fix #46829