Skip to content

src: merge CreateEnvironment() overloads #63596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jun 4, 2026
Merged

src: merge CreateEnvironment() overloads #63596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: merge CreateEnvironment() overloads 
API-compatible, but ABI-breaking, so done separately from the
original 3090def.

Signed-off-by: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
@addaleax
addaleax committed May 27, 2026
commit a21167cb6cd61ffbf86cfb0dda9a2da85ceb8996
18 changes: 0 additions & 18 deletions src/api/environment.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,24 +417,6 @@ struct InspectorParentHandleImpl : public InspectorParentHandle {
};
#endif

Environment* CreateEnvironment(
IsolateData* isolate_data,
Local<Context> context,
const std::vector<std::string>& args,
const std::vector<std::string>& exec_args,
EnvironmentFlags::Flags flags,
ThreadId thread_id,
std::unique_ptr<InspectorParentHandle> inspector_parent_handle) {
return CreateEnvironment(isolate_data,
context,
args,
exec_args,
flags,
thread_id,
std::move(inspector_parent_handle),
{});
}

Environment* CreateEnvironment(
IsolateData* isolate_data,
Local<Context> context,
Expand Down
13 changes: 2 additions & 11 deletions src/node.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,17 +698,8 @@ NODE_EXTERN Environment* CreateEnvironment(
const std::vector<std::string>& exec_args,
EnvironmentFlags::Flags flags = EnvironmentFlags::kDefaultFlags,
ThreadId thread_id = {} /* allocates a thread id automatically */,
std::unique_ptr<InspectorParentHandle> inspector_parent_handle = {});

NODE_EXTERN Environment* CreateEnvironment(
IsolateData* isolate_data,
v8::Local<v8::Context> context,
const std::vector<std::string>& args,
const std::vector<std::string>& exec_args,
EnvironmentFlags::Flags flags,
ThreadId thread_id,
std::unique_ptr<InspectorParentHandle> inspector_parent_handle,
std::string_view thread_name);
std::unique_ptr<InspectorParentHandle> inspector_parent_handle = {},
std::string_view thread_name = {});

// Returns a handle that can be passed to `LoadEnvironment()`, making the
// child Environment accessible to the inspector as if it were a Node.js Worker.
Expand Down
Loading