Skip to content

fix(schema): update vite import.meta types - #19338

Merged
danielroe merged 7 commits into
mainfrom
fix/import-meta-type
Mar 3, 2023
Merged

fix(schema): update vite import.meta types#19338
danielroe merged 7 commits into
mainfrom
fix/import-meta-type

Conversation

@clarkdo

@clarkdo clarkdo commented Feb 28, 2023

Copy link
Copy Markdown
Member

🔗 Linked issue

Fix #15645

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)

📚 Description

Sync ImportMeta from Vite and try to import from Vite exported types.

@codesandbox

codesandbox Bot commented Feb 28, 2023

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@clarkdo
clarkdo requested review from danielroe and pi0 February 28, 2023 14:47
@danielroe danielroe added 3.x 🐛 bug Something isn't working as expected 🔨 p3-minor Minor issue, should be fixed labels Mar 2, 2023
Comment thread packages/schema/src/types/global/vite.ts
@danielroe danielroe added this to the v3.3 milestone Mar 2, 2023

@danielroe danielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. ❤️

@danielroe danielroe changed the title fix(schema): sync import meta type from vite fix(schema): update vite import.meta types Mar 3, 2023
@danielroe
danielroe merged commit 654b9a2 into main Mar 3, 2023
@danielroe
danielroe deleted the fix/import-meta-type branch March 3, 2023 10:20
@clarkdo

clarkdo commented Mar 3, 2023

Copy link
Copy Markdown
Member Author

@danielroe What formatter rules are we following in nuxt now ? I don't see any prettier config, is it only editorconfig ?

Ignore me, seeing:

{
  "editor.codeActionsOnSave": {
    "source.fixAll": false,
    "source.fixAll.eslint": true
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x 🐛 bug Something isn't working as expected 🔨 p3-minor Minor issue, should be fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ViteImportMeta import.meta.glob does not change types for the eager: true flag

2 participants