Skip to content

chore: improve internal type safety - #19599

Merged
danielroe merged 1 commit into
mainfrom
chore/internal-types
Mar 11, 2023
Merged

chore: improve internal type safety#19599
danielroe merged 1 commit into
mainfrom
chore/internal-types

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This is a purely internal change and improves type strictness - these errors were coming up when type checking locally (ie. pre-build).

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe
danielroe requested a review from antfu March 11, 2023 13:43
@danielroe danielroe self-assigned this Mar 11, 2023
@codesandbox

codesandbox Bot commented Mar 11, 2023

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe
danielroe merged commit e6bbf71 into main Mar 11, 2023
@danielroe
danielroe deleted the chore/internal-types branch March 11, 2023 18:22
@danielroe danielroe mentioned this pull request Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants