Skip to content

fix(nuxi): resolve kit from nuxt modules dir - #19601

Merged
danielroe merged 3 commits into
mainfrom
fix/pnpm-resolve-kit
Mar 11, 2023
Merged

fix(nuxi): resolve kit from nuxt modules dir#19601
danielroe merged 3 commits into
mainfrom
fix/pnpm-resolve-kit

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

#14146

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

For pnp support, we should resolve kit from (1) local install and then (2) from the nuxt dependency. This means we do not need to add @nuxt/kit as a dependency without shamefully-hoist.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added 🐛 bug Something isn't working as expected cli Nuxt CLI (nuxi) 🔨 p3-minor Minor issue, should be fixed labels Mar 11, 2023
@danielroe
danielroe requested a review from pi0 March 11, 2023 14:23
@danielroe danielroe self-assigned this Mar 11, 2023
@codesandbox

codesandbox Bot commented Mar 11, 2023

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe
danielroe requested a review from antfu March 11, 2023 20:43
@danielroe danielroe added this to the v3.3 milestone Mar 11, 2023
@danielroe danielroe added the 3.x label Mar 11, 2023
@danielroe
danielroe merged commit 3684de5 into main Mar 11, 2023
@danielroe
danielroe deleted the fix/pnpm-resolve-kit branch March 11, 2023 22:36
This was referenced Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x 🐛 bug Something isn't working as expected cli Nuxt CLI (nuxi) 🔨 p3-minor Minor issue, should be fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant