Skip to content

Add challenge DF tables, routes, parsers - #57

Merged
trizin merged 13 commits into
mainfrom
issue55-add-challenge-df-tables
Jun 27, 2023
Merged

Add challenge DF tables, routes, parsers#57
trizin merged 13 commits into
mainfrom
issue55-add-challenge-df-tables

Conversation

@trizin

@trizin trizin commented Jun 22, 2023

Copy link
Copy Markdown
Collaborator

Fixes #55

Changes proposed in this PR:

  • Add DF challenge tables, routes, parsers.
  • Updated rewardsSummary table to aggregate rewards from challenge DF

@trizin trizin linked an issue Jun 22, 2023 that may be closed by this pull request
@trizin
trizin requested a review from idiom-bytes June 22, 2023 13:13
Comment thread src/comps/update/index.js
SELECT predictoor_addr AS LP_addr, 0 AS passive, 0 AS curating, OCEAN_amt FROM predictoor_rewards WHERE round = ?
) AS foo GROUP BY LP_addr`,
[round, round, round, round]
INSERT INTO rewards_summary(LP_addr, passive_amt, curating_amt, predictoor_amt, challenge_amt, round)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Comment thread db/structure.js
round INT NOT NULL,
PRIMARY KEY(winner_addr, round)
)`

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Comment thread test/fs_dir.test.js
expect(parseCsv).toHaveBeenCalledTimes(14)
expect(crypto.createHash).toHaveBeenCalledTimes(14)
expect(mockHash.update).toHaveBeenCalledTimes(14)
expect(mockHash.digest).toHaveBeenCalledTimes(14)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@idiom-bytes idiom-bytes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@trizin
trizin merged commit 07bec14 into main Jun 27, 2023
@trizin
trizin deleted the issue55-add-challenge-df-tables branch June 27, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Challenge DF Tables

2 participants