Skip to content

make disjoint pool a C structure#898

Merged
lplewa merged 12 commits into
oneapi-src:mainfrom
bratpiorka:rrudnick_disjoint_c
Feb 18, 2025
Merged

make disjoint pool a C structure#898
lplewa merged 12 commits into
oneapi-src:mainfrom
bratpiorka:rrudnick_disjoint_c

Conversation

@bratpiorka

@bratpiorka bratpiorka commented Nov 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

make Disjoint Pool a C structure. With this PR:

  • Disjoint Pool code is written in C - NOTE: there are no changes in any algorithm - any optimizations should be done in separate PRs
  • it is no longer a lib - it is always added to UMF lib sources
  • UMF_BUILD_LIBUMF_POOL_DISJOINT option is removed
  • few white-box test cases where we look at internal structures are added - more could be added in separate PRs

@bratpiorka bratpiorka requested a review from a team as a code owner November 14, 2024 13:30
@lukaszstolarczuk lukaszstolarczuk marked this pull request as draft November 14, 2024 13:39
@bratpiorka bratpiorka force-pushed the rrudnick_disjoint_c branch 3 times, most recently from 97807f1 to 3521be5 Compare November 18, 2024 10:14
@lplewa lplewa mentioned this pull request Nov 19, 2024
Closed
@bratpiorka bratpiorka force-pushed the rrudnick_disjoint_c branch 8 times, most recently from 17d00a2 to 9b22721 Compare November 27, 2024 09:57
github-advanced-security[bot]
github-advanced-security AI found potential problems Nov 27, 2024
View reviewed changes
Comment thread src/pool/pool_disjoint.c Fixed
Comment thread src/pool/pool_disjoint.c Fixed
@vinser52 vinser52 mentioned this pull request Nov 27, 2024
Merged
3 tasks
@bratpiorka bratpiorka force-pushed the rrudnick_disjoint_c branch 14 times, most recently from cdad0f1 to 4a8935a Compare December 6, 2024 15:03
@bratpiorka bratpiorka force-pushed the rrudnick_disjoint_c branch 8 times, most recently from eb10fca to 8733b28 Compare January 25, 2025 14:36
PatKamin
PatKamin reviewed Jan 28, 2025
View reviewed changes
Comment thread .github/workflows/reusable_multi_numa.yml Outdated
PatKamin
PatKamin reviewed Jan 29, 2025
View reviewed changes
Comment thread test/supp/helgrind-umf_test-disjoint_pool.supp Outdated
ldorau
ldorau requested changes Feb 17, 2025
View reviewed changes
Comment thread src/base_alloc/base_alloc_global.c Outdated
Comment thread src/base_alloc/base_alloc_global.c
@ldorau

ldorau commented Feb 17, 2025

Copy link
Copy Markdown
Contributor

@bratpiorka Please rebase and resolve merge conflicts

@bratpiorka

bratpiorka commented Feb 18, 2025

Copy link
Copy Markdown
Contributor Author

@bratpiorka Please rebase and resolve merge conflicts

done

bratpiorka and others added 12 commits February 18, 2025 11:08
@bratpiorka
do nothing in ba_global_free if ba is destroyed
df1de3a
@bratpiorka
add utils min/max functions
1ee248c
@bratpiorka
add utils_compare_exchange function
cd6efbb
@bratpiorka
make disjoint pool a C structure
76b4b5c
@lplewa @bratpiorka
reenable disjoint pool benchmark
41429f4
@lplewa @bratpiorka
fix all sizeof
fd56adc 
Signed-off-by: Łukasz Plewa <lukasz.plewa@intel.com>
@lplewa @bratpiorka
add missing error check for allocation
a74fcb4 
Signed-off-by: Łukasz Plewa <lukasz.plewa@intel.com>
@lplewa @bratpiorka
remove not needed forward declarations
9ec909e 
Signed-off-by: Łukasz Plewa <lukasz.plewa@intel.com>
@lplewa @bratpiorka
remove distiguation between "chunked slab" and "full slab"
75dea95 
Instead having two modes - we can have only chunked slabs and full
slabs are just a chunked slab with one chunk. This removes extra
complexity in the code. Should not have performance impact, as we
added few extra steps for big allocations, but removed extra branch in
the code.

Signed-off-by: Łukasz Plewa <lukasz.plewa@intel.com>
@lplewa @bratpiorka
do not allocate slab->iter dynamically
6bb22d8 
There is no reason to do so. This is only extra performance overhead.

Signed-off-by: Łukasz Plewa <lukasz.plewa@intel.com>
@lplewa @bratpiorka
rename slab_Reg to pool_register_slab
b6181b6 
this improves redability, and reduces "spaghetti" in the code

Signed-off-by: Łukasz Plewa <lukasz.plewa@intel.com>
@lplewa @bratpiorka
Rename bucket_capacity to bucket_ma_pooled_slabs
368ab19 
this function has nothing releated to capacity.

input parameter to disjointpool should also be renamed, but this is
topic for the diffrent pull request

Signed-off-by: Łukasz Plewa <lukasz.plewa@intel.com>
@ldorau

ldorau commented Feb 18, 2025

Copy link
Copy Markdown
Contributor

Hanging on the Windows CUDA build :-) ...

@lukaszstolarczuk lukaszstolarczuk mentioned this pull request Feb 19, 2025
Closed
10 tasks
@bratpiorka bratpiorka mentioned this pull request Feb 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldorau ldorau ldorau approved these changes
@lplewa lplewa lplewa approved these changes
@lukaszstolarczuk lukaszstolarczuk Awaiting requested review from lukaszstolarczuk
@PatKamin PatKamin Awaiting requested review from PatKamin
@igchor igchor Awaiting requested review from igchor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.11.x

Development

Successfully merging this pull request may close these issues.

7 participants

@bratpiorka @igchor @ldorau @lplewa @lukaszstolarczuk @PatKamin @github-advanced-security