Skip to content

L0 provider: implement support for defer and blocking free#963

Merged
lukaszstolarczuk merged 1 commit into
oneapi-src:mainfrom
igchor:level_zero_provider_ext_free
Jan 16, 2025
Merged

L0 provider: implement support for defer and blocking free#963
lukaszstolarczuk merged 1 commit into
oneapi-src:mainfrom
igchor:level_zero_provider_ext_free

Conversation

@igchor

@igchor igchor commented Dec 4, 2024

Copy link
Copy Markdown
Contributor

Description

This feature is necessary to properly support urUSMFree for v2 L0 adapter.

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

@bratpiorka

bratpiorka commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

@igchor do we need this for 0.10x / 2025.1?

vinser52
vinser52 requested changes Dec 5, 2024
View reviewed changes
Comment thread src/provider/provider_level_zero.c
@igchor

igchor commented Dec 5, 2024

Copy link
Copy Markdown
Contributor Author

@igchor do we need this for 0.10x / 2025.1?

No, for now I only want to use it for v2 L0 adapter which will not be released as part of 2025.1

vinser52
vinser52 reviewed Dec 5, 2024
View reviewed changes
Comment thread include/umf/providers/provider_level_zero.h
@igchor igchor force-pushed the level_zero_provider_ext_free branch from 98b4e2a to 76672ed Compare December 5, 2024 15:27
@vinser52

vinser52 commented Dec 6, 2024

Copy link
Copy Markdown

As a first step, I wanted to test this in UR (that's why I kept this as draft).

@igchor So we are not merging that till you confirm that UR works with the new UMF L0 config options and they do what UR needs?

@igchor

igchor commented Dec 6, 2024

Copy link
Copy Markdown
Contributor Author

As a first step, I wanted to test this in UR (that's why I kept this as draft).

@igchor So we are not merging that till you confirm that UR works with the new UMF L0 config options and they do what UR needs?

Yes, I'll undraft the PR once I manage to test this in UR

vinser52
vinser52 reviewed Dec 9, 2024
View reviewed changes
Comment thread include/umf/providers/provider_level_zero.h
@igchor igchor force-pushed the level_zero_provider_ext_free branch 2 times, most recently from bb2d469 to 477edb6 Compare December 10, 2024 20:38
@lplewa

lplewa commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

any tests?

@igchor igchor force-pushed the level_zero_provider_ext_free branch from 477edb6 to 6683056 Compare January 9, 2025 17:46
@igchor

igchor commented Jan 9, 2025

Copy link
Copy Markdown
Contributor Author

any tests?

For now, this will only be tested in UR. We can consider adding some tests in the future, but this will require adding a dependency on igc or committing a binary (the test requires executing a kernel).

@igchor igchor marked this pull request as ready for review January 9, 2025 18:00
@igchor igchor requested a review from a team as a code owner January 9, 2025 18:00
@igchor igchor force-pushed the level_zero_provider_ext_free branch from 6683056 to d19bc63 Compare January 15, 2025 18:20
@igchor igchor force-pushed the level_zero_provider_ext_free branch from d19bc63 to 39f77a1 Compare January 15, 2025 23:30
@igchor

igchor commented Jan 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@bratpiorka could you please merge this? I have a few more fixes/improvements pending that but I'd like this to be merged first

@lukaszstolarczuk lukaszstolarczuk merged commit 7dc640c into oneapi-src:main Jan 16, 2025
@igchor igchor deleted the level_zero_provider_ext_free branch January 16, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinser52 vinser52 vinser52 approved these changes
@ldorau ldorau ldorau approved these changes
@bratpiorka bratpiorka bratpiorka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@igchor @bratpiorka @vinser52 @lplewa @ldorau @lukaszstolarczuk