Skip to content

add fixed provider#976

Merged
lukaszstolarczuk merged 1 commit into
oneapi-src:mainfrom
lplewa:fixed
Dec 16, 2024
Merged

add fixed provider#976
lukaszstolarczuk merged 1 commit into
oneapi-src:mainfrom
lplewa:fixed

Conversation

@lplewa

@lplewa lplewa commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

@lplewa lplewa requested a review from a team as a code owner December 6, 2024 14:56
Comment thread test/provider_fixed_memory.cpp
Comment thread src/provider/provider_fixed_memory.c
Comment thread src/provider/provider_fixed_memory.c Outdated
Comment thread include/umf/providers/provider_fixed_memory.h
Comment thread src/coarse/coarse.c Outdated

@ldorau ldorau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR depends on #981 and should be merged after it.

After having applied the requested changes the tests starts to fail and they should be fixed accordingly.

Comment thread src/coarse/coarse.c Outdated
Comment thread src/provider/provider_fixed_memory.c
Comment thread src/provider/provider_fixed_memory.c
Comment thread src/provider/provider_fixed_memory.c
Comment thread src/provider/provider_fixed_memory.c Outdated
Comment thread src/provider/provider_fixed_memory.c Outdated
Comment thread src/provider/provider_fixed_memory.c Outdated
Comment thread src/provider/provider_fixed_memory.c
Comment thread src/provider/provider_fixed_memory.c Outdated
Comment thread src/provider/provider_fixed_memory.c
@ldorau

ldorau commented Dec 10, 2024

Copy link
Copy Markdown
Contributor

#981 has been merged. Rebase please.

Comment thread include/umf/providers/provider_fixed_memory.h
Comment thread src/libumf.def
umfFileMemoryProviderParamsSetPath
umfFileMemoryProviderParamsSetProtection
umfFileMemoryProviderParamsSetVisibility
umfFixedMemoryProviderOps

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add new functions to LIBUMF_0.11 set (requires #974 merged + rebase)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it will be merged....

@lplewa lplewa force-pushed the fixed branch 4 times, most recently from e9f92ca to 4e91bc9 Compare December 12, 2024 13:48
Comment thread README.md Outdated
@lukaszstolarczuk lukaszstolarczuk merged commit 95861f3 into oneapi-src:main Dec 16, 2024
@bratpiorka bratpiorka mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants