Skip to content

Codespell#994

Merged
lukaszstolarczuk merged 2 commits into
oneapi-src:mainfrom
luszczewskakasia1:codespell
Dec 19, 2024
Merged

Codespell#994
lukaszstolarczuk merged 2 commits into
oneapi-src:mainfrom
luszczewskakasia1:codespell

Conversation

@luszczewskakasia1

@luszczewskakasia1 luszczewskakasia1 commented Dec 12, 2024 •
edited by ldorau
Loading

Copy link
Copy Markdown
Contributor

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

@luszczewskakasia1
fix codespell errors in CODE_OF_CONDUCT and reusable_valgrind.yml
0c75171 
Signed-off-by: kluszcze <katarzyna.luszczewska@intel.com>
@luszczewskakasia1 luszczewskakasia1 requested a review from a team as a code owner December 12, 2024 12:51
@luszczewskakasia1 luszczewskakasia1 mentioned this pull request Dec 12, 2024
Closed
10 tasks
lukaszstolarczuk
lukaszstolarczuk reviewed Dec 12, 2024
View reviewed changes
Comment thread .github/scripts/codespell.sh Outdated
Comment thread .github/workflows/reusable_checks.yml Outdated
Comment thread .github/workflows/reusable_checks.yml Outdated
Comment thread .github/scripts/codespell.sh Outdated
Comment thread .github/scripts/codespell.sh Outdated
Comment thread .github/scripts/codespell.sh Outdated
Comment thread .github/scripts/codespell.sh Outdated
PatKamin
PatKamin reviewed Dec 13, 2024
View reviewed changes
Comment thread .github/scripts/codespell.sh Outdated
PatKamin
PatKamin reviewed Dec 13, 2024
View reviewed changes
Comment thread .github/scripts/codespell.sh Outdated
@luszczewskakasia1 luszczewskakasia1 force-pushed the codespell branch 2 times, most recently from b2536bf to 31715a3 Compare December 17, 2024 15:01
ldorau
ldorau reviewed Dec 17, 2024
View reviewed changes
Comment thread .github/scripts/run-codespell.py Outdated
ldorau
ldorau requested changes Dec 18, 2024
View reviewed changes

@ldorau ldorau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Run codespell step does not fail if codespell finds errors:
https://github.com/ldorau/unified-memory-framework/actions/runs/12388725376/job/34580341701

ldorau
ldorau requested changes Dec 18, 2024
View reviewed changes
Comment thread .github/scripts/run-codespell.py Outdated
Comment thread .github/scripts/run-codespell.py Outdated
PatKamin
PatKamin reviewed Dec 18, 2024
View reviewed changes
Comment thread .github/scripts/run-codespell.py Outdated
PatKamin
PatKamin reviewed Dec 18, 2024
View reviewed changes
Comment thread .github/workflows/reusable_checks.yml
PatKamin
PatKamin reviewed Dec 18, 2024
View reviewed changes
Comment thread .github/scripts/run-codespell.py Outdated
@ldorau

ldorau commented Dec 18, 2024

Copy link
Copy Markdown
Contributor

@lukaszstolarczuk @PatKamin re-review please

lukaszstolarczuk
lukaszstolarczuk reviewed Dec 19, 2024
View reviewed changes
Comment thread .github/workflows/reusable_checks.yml
Comment thread .github/scripts/run-codespell.py Outdated
@luszczewskakasia1
add python script to run codespell scan
f70c7ca 
Signed-off-by: Katarzyna Luszczewska <katarzyna.luszczewska@intel.com>
lukaszstolarczuk
lukaszstolarczuk approved these changes Dec 19, 2024
View reviewed changes

@lukaszstolarczuk lukaszstolarczuk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx! LGTM

@lukaszstolarczuk lukaszstolarczuk merged commit 88bb108 into oneapi-src:main Dec 19, 2024
@lukaszstolarczuk lukaszstolarczuk mentioned this pull request Dec 30, 2024
Closed
@luszczewskakasia1 luszczewskakasia1 deleted the codespell branch January 28, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldorau ldorau ldorau approved these changes
@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk approved these changes
@PatKamin PatKamin PatKamin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@luszczewskakasia1 @ldorau @lukaszstolarczuk @PatKamin