Update CI for OPS 2.0 - #1043
Merged
Merged
Conversation
CI for 2.0 was set up before OpenMM was available on > 3.7.
I think the files used are old enough that they require workarounds that were removed when deprecations were removed. If this fixes, then I'll create new files for the dev-2.0 branch.
Member
Author
|
This also required creating new files for Python 3.7 that don't use old workarounds. The old files (created in Python 3.6 requiring workarounds due to changes in the structure of interface sets) are still used on the main branch. This is ready for review and comment. I will leave it open for at least 24 hours, merging no earlier than Wed 04 Aug 00:00 GMT (Tue 03 Aug 20:00 my local). |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main development branch CI is in
.github/workflows/tests.yml. The CI for the 2.0 development branch is in.github/workflows/test-2.0.yml. This PR ports improvements intests.ymlintotest-2.0.yml(and, of course, targets thedev-2.0branch).Useful improvements:
iter_generatefor OPS 2.0 #1042, I'll feel a lot better having the more thorough test suite.