Skip to content

updated OpenMMEngine docstring, adresses #769 - #770

Merged
dwhswenson merged 1 commit into
openpathsampling:masterfrom
hejung:fix_OpenMMEngine_docstring
Jul 25, 2019
Merged

updated OpenMMEngine docstring, adresses #769#770
dwhswenson merged 1 commit into
openpathsampling:masterfrom
hejung:fix_OpenMMEngine_docstring

Conversation

@hejung

@hejung hejung commented Apr 17, 2018

Copy link
Copy Markdown
Contributor

Changes to the docstring to reflect current implementation.

(Maintainer edit: closes #769)

hejung added a commit to hejung/openpathsampling that referenced this pull request Apr 18, 2018
@dwhswenson

Copy link
Copy Markdown
Member

Please note that we have changed to the OPS license from LGPL (2.1 or later) to MIT. For any pull request to OPS that was started while the license was still LGPL, I need an explicit confirmation that you approve of the license change. Please add a comment with something like "The changes in this pull request are licensed under the MIT license."

@hejung

hejung commented Jul 24, 2019

Copy link
Copy Markdown
Contributor Author

The changes in this pull request are licensed under the MIT license.

@dwhswenson dwhswenson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the improving the documentation!

@dwhswenson
dwhswenson merged commit afadc85 into openpathsampling:master Jul 25, 2019
@dwhswenson dwhswenson added docs issues/PRs related to documentation misc PR labels Jul 25, 2019
This was referenced Dec 11, 2019
@hejung
hejung deleted the fix_OpenMMEngine_docstring branch February 23, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs issues/PRs related to documentation misc PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenMMEngine ignores platform option

2 participants